Comment on attachment 8782423 [details] Bug 1296265 - Remove (unused) initial assignment to nsRuleNode.cpp variable "scriptLevelAdjustedParentSize". https://reviewboard.mozilla.org/r/72602/#review70880 Thanks for catching & fixing this! r=me, with one request -- before landing, please change the commit message so that it describes the change, rather than simply quoting the warning being addressed. (This is a general rule for Gecko commit messages -- see https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Committing_Rules_and_Responsibilities#Checkin_comment for more on this.) Suggested replacement commit message: Bug 1296265 - Collapse assignments to nsRuleNode.cpp variable "scriptLevelAdjustedParentSize", since the first one is never used. r=dholbert

Comment on attachment 8782423 [details] Bug 1296265 - Remove (unused) initial assignment to nsRuleNode.cpp variable "scriptLevelAdjustedParentSize". https://reviewboard.mozilla.org/r/72602/#review70880 Gahhh, sorry for the """ junk in my suggested commit message above. Those were originally quote characters, but MozReview bungled them up due to a version of bug 1283024.

Alternate (shorter, possibly clearer) commit message: Bug 1296265 - Remove (unused) initial assignment to nsRuleNode.cpp variable "scriptLevelAdjustedParentSize". r=dholbert

Note that this made sense when the MOZ_MATHML #ifdefs were present, but probably should have been removed along with them.

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9de2153ec067 Remove (unused) initial assignment to nsRuleNode.cpp variable "scriptLevelAdjustedParentSize". r=dholbert